On Wed, 24 Nov 2021 17:23:30 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address feedback
>
> modules/javafx.web/src/main/java/javafx/scene/web/WebView.java line 1291:
>
>> 1289: setOnDragDone(event -> {
>> 1290: mimes = null;
>> 1291: values = null;
>
> Is it possible for `OnDragDone` to be missed? If so, I wonder if it is a good
> idea to also set `mimes` and `values` to `null` in the `OnDragDetected`
> handler?
It makes sense. Done.
> tests/manual/web/dnd/drag.html line 13:
>
>> 11: </a>
>> 12: </body>
>> 13: </html>
>
> Minor: missing newline at end of file.
Done
-------------
PR: https://git.openjdk.java.net/jfx/pull/680
