On Fri, 10 Dec 2021 18:56:43 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8273096: Add support for H.265/HEVC to JavaFX Media [v3] > > modules/javafx.media/src/main/native/gstreamer/plugins/av/videodecoder.c line > 525: > >> 523: if (decoder->sws_context == NULL || decoder->dest_frame == NULL || >> 524: decoder->sws_scale_func == NULL) >> 525: return TRUE; > > Should this be `return FALSE;`? Not really. videodecoder_init_converter() should fail if we need converter, but did not able to initialize it. videodecoder_convert_frame() return TRUE here, since it assumes that it will never be called if we need converter and fail to initialize it. So, TRUE here means we do not need to convert frame. I modified this logic by checking base->frame->format value to make it clear. ------------- PR: https://git.openjdk.java.net/jfx/pull/649
