On Fri, 17 Dec 2021 12:21:37 GMT, Johan Vos <j...@openjdk.org> wrote:
>> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Minor updates to address pending review comments that I did last year, but >> forgot to push > > CONTRIBUTING.md line 57: > >> 55: A developer with an active OpenJDK ID can file a bug directly in JBS. >> 56: >> 57: TIP: A GitHub pull request (PR) should not be the first time we hear >> about your proposed change to OpenJFX. Unless clearly identified as a Draft >> or work-in-progress (WIP), we will usually close a pull request that isn't >> associated with an existing bug report. Reading the policies below will help >> you in getting your change approved. > > forward reference to Draft or WIP, so maybe add (as explained later)? Done. > CONTRIBUTING.md line 179: > >> 177: with the environment variable `JAVA_HOME` referencing the path to Java >> home for >> 178: your JDK installation. By default, tests use the same runtime as >> `JAVA_HOME`. >> 179: Currently OpenJFX builds are running on JDK 11 through JDK 15. JDK 14 >> is recommended. > > JDK 17 Done. > CONTRIBUTING.md line 252: > >> 250: >> 251: TIP: a pull request is _not_ the starting point, since that skips the >> first two important steps and jumps right into >> 252: "given this new feature, and an API definition that specifies it, >> please review my proposed implementation". > > I wonder if we should add something like "A PR is also not the end point, as > code that is included in the repository should be maintained." I don't think > that really belongs here, but it is a point I always check when reviewing a > PR: what is the estimated maintenance for this PR? It might be better in the > "Code Reviews" section on the OpenJFX wiki though. This is a good idea, and is part of what we mean when asking contributors of features to think about "stewardship". So I think adding it either here or in the code review section of the Wiki is good. ------------- PR: https://git.openjdk.java.net/jfx/pull/303
