On Sat, 18 Dec 2021 16:34:21 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> Btw, you don't need the "abs" for the gLightAttenuation check (you don't 
>> have it now when checking against 0.5) so you can just change it to 
>> `gLightAttenuation[i].w < EPSILON` which seems cleaner than testing against 
>> 0.5.
>
> I see you kept it as 0.5 and documented it. That's fine, too.

I just didn't want to mess with the math and need to retest everything just for 
this. If I add the EPSILON checks for falloff later I will use it there too.

-------------

PR: https://git.openjdk.java.net/jfx/pull/548

Reply via email to