> Making the initial listener of the ListProperty weak fixes the problem. > The same is fixed for Set and Map. > Due to a smart implementation, this is done without any performance drawback. > (The trick is to have an object, which is both the WeakReference and the > Changelistener) > By implying the same trick to the InvalidationListener, this should even > improve the performance of the collection properties.
Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision: JDK-8277848 Further optimization based code review. This Bugfix should now event improve the performance ------------- Changes: - all: https://git.openjdk.java.net/jfx/pull/689/files - new: https://git.openjdk.java.net/jfx/pull/689/files/f9b7009b..ec90b3d1 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=689&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=689&range=01-02 Stats: 106 lines in 3 files changed: 15 ins; 63 del; 28 mod Patch: https://git.openjdk.java.net/jfx/pull/689.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/689/head:pull/689 PR: https://git.openjdk.java.net/jfx/pull/689
