On Thu, 23 Dec 2021 17:43:19 GMT, Florian Kirmaier <fkirma...@openjdk.org> 
wrote:

> Fixing memoryleak, related to touch events in ScrollPaneWhen touchDetected or 
> mouseDown is true, the sbTouch animation is running, 
> and the node is removed from the Scene, then the animation will never stop, 
> causing a memory leak.
> A simple fix is to also check, whether the Node is visible, by checking the 
> "isTreeShowing" property.

Two quick questions:

1. The fix checks whether or not the node is treeShowing at the time the 
`startSBReleasedAnimation` method is called. Is this sufficient? If a node's 
tree showing state changes, is it guaranteed that this method will be called?
2. Can you provide an automated test for this?

-------------

PR: https://git.openjdk.java.net/jfx/pull/701

Reply via email to