On Wed, 12 Jan 2022 16:14:16 GMT, Jose Pereda <jper...@openjdk.org> wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Releasing dummy NSView
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassWindow.m line 847:
>
>> 845: {
>> 846: // If the contentView is set to nil within
>> performKeyEquivalent: the OS will crash.
>> 847: NSView* dummy = [[NSView alloc] initWithFrame:
>> NSMakeRect(0, 0, 10, 10)];
>
> The view could be also created with a (0, 0, 0, 0) rect, couldn't it?
I don't know. I'm always skeptical of 0 size rectangles. I'd either leave it
as-is or maybe use a `(0,0,1,1)` rectangle.
-------------
PR: https://git.openjdk.java.net/jfx/pull/714
