On Tue, 25 Jan 2022 13:45:54 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8277122: Added test for setting a negative divider position + improved >> readability > > modules/javafx.controls/src/test/java/test/javafx/scene/control/SplitPaneTest.java > line 1387: > >> 1385: assertTrue(layoutCounter.get() > 0); >> 1386: stageLoader.dispose(); >> 1387: } > > the stageLoader is not disposed if the test fails - a (recently introduced :) > general pattern is to use an instance field that's disposed in the test > cleanup Hm, is this really needed? Not sure, are there any side effects by the `StageLoader` like this when a test failed? Just asking since the `StageLoader` is used a lot like this. And since the tests normally run green unless you may change something locally (on the JavaFX Pipeline it should never be red), it would probably never affect anything (or maybe it does?). ------------- PR: https://git.openjdk.java.net/jfx/pull/669
