On Fri, 4 Feb 2022 17:33:18 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback from reviewer > > modules/javafx.controls/src/main/java/javafx/scene/control/ControlUtils.java > line 172: > >> 170: .map(TablePositionBase::getRow) >> 171: .filter(removeRowFilter) >> 172: .distinct() > > Maybe `distinct` should be applied before `filter`. This can cut down the > number of times the predicate is invoked (which iterates over all selected > cells, so it may be a performance issue for large selections). Makes sense. Done ------------- PR: https://git.openjdk.java.net/jfx/pull/709
