Sounds good. :) I think you just can push the branch, but not sure. I think only people with the 'contributor' title can push to it, which I'm not yet.
It might not be simpler, but more visible and on a more common location. But yeah, the look and observing part can also be done in your fork. -- Marius Gesendet: Montag, 21. Februar 2022 um 14:21 Uhr Von: "Jeanette Winzenburg" <faste...@swingempire.de> An: "Marius Hanl" <mariush...@web.de> Cc: "openjfx-dev" <openjfx-dev@openjdk.java.net> Betreff: Re: Aw: Sneak preview: cell edit api to support commit-on-focusLost hmm .. yeah, will do .. once it's less sneak and less pre ;) Still fighting .. Though not entirely certain how to work with the sandbox: technically, that would be fork the sandbox, create a branch, merge my changes into that branch and push? And not sure how that would be simpler for others (except when actually cooperating) than now looking/monitoring the changes in my jfx fork? -- Jeanette Zitat von Marius Hanl <mariush...@web.de>: > Can you may create a branch at the jfx sandbox repo? > [1]https://github.com/openjdk/jfx-sandbox > > Then I can more easily compare and check it out. (and monitor it :)) > > -- Marius > GESENDET: Freitag, 11. Februar 2022 um 18:03 Uhr > VON: "Jeanette Winzenburg" <faste...@swingempire.de> > AN: "openjfx-dev" <openjfx-dev@openjdk.java.net> > BETREFF: Sneak preview: cell edit api to support commit-on-focusLost > > Hi folks, > > after fixing a bunch of edit-related issues, time feels right for > nudging elephant out of the room :) Which is the bigger goal of > supporting commit-on-focusLost. > > Working on a PoC (ListView/-Cell only) in a branch of my fork > [2]https://github.com/kleopatra/jfx/tree/dokeep-edit-api-editstate with > an overview of suggested changes > [3]https://github.com/kleopatra/swingempire-fx/wiki/CellEditAPI and a > example driver as gist > [4]https://gist.github.com/kleopatra/447344183e017537c21f7905a062396d > > Still rough, but working: all current unit tests still passing (a > bunch of my own not, and the new api is barely tested) and many of the > requested requirements can be implemented (see code in the example and > the table of use-cases in the overview) > > Any feedback - for the good or for the bad - highly welcome :) > > -- Jeanette > > References 1. https://github.com/openjdk/jfx-sandbox 2. https://github.com/kleopatra/jfx/tree/dokeep-edit-api-editstate 3. https://github.com/kleopatra/swingempire-fx/wiki/CellEditAPI 4. https://gist.github.com/kleopatra/447344183e017537c21f7905a062396d
