On Fri, 25 Feb 2022 17:54:48 GMT, Hima Bindu Meda <d...@openjdk.java.net> wrote:

>> Basically, buttons property is a mask which represents the button/buttons 
>> clicked on the mouse.
>>     It is observed that event.buttons property is set to 0 when there is 
>> mouse press or drag event.This behaviour is observed only with javafx 
>> webView.Other browsers set the buttons property to 1, when there is mouse 
>> press or drag.
>>      The issue happens because the buttons property is not updated in the 
>> framework.
>>      Added implementation to update and propagate the buttons property from 
>> javafx platform to native webkit.Added a robot test case for the same.
>>    Performed sanity testing with the added implementation and the buttons 
>> property is compliant with the specification mentioned in 
>> https://w3c.github.io/pointerevents/#the-buttons-property.
>
> Hima Bindu Meda has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Use ESC key so that the popup, if any, disappears

Looks good. The test now passes for me on all platforms.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/742

Reply via email to