On Mon, 18 Apr 2022 18:38:03 GMT, Alexander Matveev <almat...@openjdk.org> 
wrote:

>> - GStreamer updated to 1.20.1 and GLib updated to 2.72.0.
>> - No changes to our code, except in GstAudioSpectrum.cpp 
>> g_atomic_pointer_compare_and_exchange() was changed to 
>> g_atomic_pointer_set(). For some reason I was not able to get code compiled 
>> with g_atomic_pointer_compare_and_exchange() used from C++ code. Also, I do 
>> not see a need to use g_atomic_pointer_compare_and_exchange(), since 
>> m_pHolder always equals to old_holder.
>> - Tested on all platforms with all supported media streams.
>
> Alexander Matveev has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8283218: Update GStreamer to 1.20.1 [v4]

The latest patch builds and runs for me now on Ubuntu 16.04. I do want to make 
sure that regardless of whatever system we build it on, the binary is able to 
run on the oldest version we are targeting. Otherwise, a binary built on, say, 
Oracle Linux 7.x or Ubuntu 20.04 might not run on an Ubuntu 16.04 system. 
Basically what we don't want is to be dependent on a particular version of 
libraries at compile time.

The more I think about it, the best long term solution (not this time) is 
probably to build and deliver glib-lite.so on Linux.

-------------

PR: https://git.openjdk.java.net/jfx/pull/768

Reply via email to