On Wed, 25 May 2022 12:45:59 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments applied
>
> modules/javafx.web/src/main/native/Source/WebCore/bindings/java/EventListenerManager.cpp
> line 34:
>
>> 32: EventListenerManager& EventListenerManager::get_instance()
>> 33: {
>> 34: static NeverDestroyed<EventListenerManager> sharedManager;
>
> This does behave well as a singleton class. But I think the instance should
> be class member variable or a pointer.
Most of the singleton class implementation is as above in Webkit.
-------------
PR: https://git.openjdk.java.net/jfx/pull/799
