On Wed, 23 Feb 2022 22:43:58 GMT, Marius Hanl <[email protected]> wrote:
>> This PR fixes an issue where the item of the table row is null, although the >> cell itself is not empty (non null value). >> >> The fix is to call `indexChanged(..)` immediately after the index was >> changed, but before all `indexProperty()` listener are notified. >> The then notified listener in `TableRowSkinBase` will update the underlying >> cells, which will eventually result in an call to `updateItem(..)`, where >> the NPE happened (and now not anymore, since the table row is now correctly >> setup before). >> >> There is one special case: When the index didn't changed at all, we manually >> call `indexChanged(..)` (just like before) since when a property is not >> changed, `invalidated()` is not called, but we need to notify subclasses >> that `updateIndex(..)` was called. > > Marius Hanl has updated the pull request incrementally with one additional > commit since the last revision: > > 8251483: Updated copyright year Looks good to me. ------------- Marked as reviewed by aghaisas (Reviewer). PR: https://git.openjdk.org/jfx/pull/741
