On Thu, 30 Jun 2022 22:46:26 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with five
>> additional commits since the last revision:
>>
>> - Move private binding classes to com.sun.javafx.binding package
>> - Add note to Bindings#select to consider ObservableValue#flatMap
>> - Fix bug invalidation bug in FlatMappedBinding
>>
>> Also fixed a secondary issue where the indirect source of the binding
>> was unsubscribed and resubscribed each time its value was recomputed.
>>
>> Add additional comments to clarify how FlatMappedBinding works.
>>
>> Added test cases for these newly discovered issues.
>> - Fix typos in LazyObjectBinding
>> - Rename observeInputs to observeSources
>
> modules/javafx.base/src/main/java/javafx/beans/binding/Bindings.java line 443:
>
>> 441: * Since 19, it is recommended to use {@link
>> ObservableValue#flatMap(java.util.function.Function)}
>> 442: * to select a nested member of an {@link ObservableValue}.
>> 443: * </p>
>
> This should be added to the CSR.
I've updated the CSR.
-------------
PR: https://git.openjdk.org/jfx/pull/675
