On Tue, 5 Jul 2022 21:45:54 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> 1. I would rather leave the apps/ for day 2, if I may. >> 2+3. Currently, on Mac, I don't see any issues related to build/... >> folders. I think, generally speaking, it's a bad idea to refer to derived >> folders as source - it complicates the build process in Eclipse. Does my >> branch fail on windows in Eclipse, Nir? I mean, do I need to make changes >> to address this comment? > > I don't get any errors on the graphics module, I'm suggesting that you remove > the entries: > > <classpathentry kind="src" path="build/gensrc/jsl-prism"/> > <classpathentry kind="src" path="build/gensrc/jsl-decora"/> good point. removing <classpathentry kind="src" path="build/gensrc/jsl-prism"/> <classpathentry kind="src" path="build/gensrc/jsl-decora"/> ------------- PR: https://git.openjdk.org/jfx/pull/804