On Tue, 5 Jul 2022 19:23:13 GMT, Jose Pereda <[email protected]> wrote:

> This PR solves an IAE exception that happens when invoking a ColorChooser 
> control within a WebView, by getting the r, g, b values from the Color before 
> calling the colorChooser.
> 
> A system test is included, to verify that there is no exception and the two 
> native functions that are modified produce the expected color components.

Looks good. I confirm that the new test fails without the fix and passes with 
the fix. I see the construct `auto [r, g, b, a] = 
color.toSRGBALossy<uint8_t>()` is used in other places to similarly extract the 
color, so looks like it was just missed in the two places you found.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.org/jfx/pull/809

Reply via email to