On Thu, 7 Jul 2022 10:12:58 GMT, Johan Vos <j...@openjdk.org> wrote:

> I did a reformat on the sections that you mentioned. Doing a reformat with 
> NetBeans on the whole file would cause too many changes that would hide the 
> real changes, so that is probably a bit too much?

Perfect (and yes, I prefer to only reformat the sections being modified).

>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListViewKeyInputTest.java
>>  line 1837:
>> 
>>> 1835:     }
>>> 1836: 
>>> 1837:     @Ignore // there is no guarantee that there will be 8 selected 
>>> items (can be 7 as well)
>> 
>> Ideally we would have an open bug ID for an `@Ignore`d test. In this case, 
>> it might or might not be worth filing one to fix the test.
>
> I filed https://bugs.openjdk.org/browse/JDK-8289909 for this.

Thanks. In that case can you update the annotiation to `@Ignore("JDK-8289909")`?

-------------

PR: https://git.openjdk.org/jfx/pull/808

Reply via email to