On Mon, 27 Jun 2022 23:47:21 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> summary of changes: >> - fixed .classpath files >> - set UTF-8 encoding in the eclipse project config files >> >> the list of eclipse projects that do compile in Eclipse as a result of this >> PR are: >> - base >> - controls >> - fxml >> - graphics >> - jfx >> - media >> - swing >> - swt >> - systemTests (can be dropped in favor ot tests >> - tests >> - web >> >> Not supported (should be removed from workspace or simply closed): >> - apps >> - apps/* >> - buildSrc > > Once the OCA status has been verified, the review can proceed formally. > > @nlisker Would you be able to review these changes? I'm not an Eclipse user. > > @kleopatra your input would be helpful, too, if you are willing to take a > look. @kevinrushforth 2 questions that are relevant to the future work on the Eclipse files: 1. The jfx gradle build treats `tests/system` as a project but not its parent `test`. The cleanup talked about wiring up `manual` and `performance` to the build. Do you have an idea when the work on this will start? 2. The cleanup also talked about moving `apps/toys` and `apps/tests` to `tests/manual`. This means that `apps/samples` is the only folder to remain in `apps` (`apps/performance` was removed already). Is there a point to keeping the hierarchy? Maybe just `apps` or just `samples` will be sufficient in this case. ------------- PR: https://git.openjdk.org/jfx/pull/804
