On Fri, 8 Jul 2022 21:37:47 GMT, Andy Goryachev <d...@openjdk.org> wrote:
> The fix includes: > - renaming of offending methods to avoid confusion > - explicitly declaring the offending methods as private +1 for JLS While I agree that leaving the code as is does not cause issues (since the methods are not getting overriden), it might fall under maintainability rubric. Especially in the case of BaseShaderGraphics, where a human surely gets confused. Some people do have eclipse and can F3 to see the superclass. So I would suggest to merge all of my changes. If this is unacceptable, at least merge the BaseShaderGraphics change, as it is rather confusing. The good thing is that we only have a very few places, so the probability of confusion due to this issue is rather low. ------------- PR: https://git.openjdk.org/jfx/pull/824
