On Wed, 13 Jul 2022 05:06:45 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:

>> Issue: In a TreeTableView if root item has no children then TreeTableView 
>> does not retain if a sort order is set.
>> 
>> Cause: This is a regression of fix for 
>> [JDK-8256283](https://bugs.openjdk.org/browse/JDK-8256283), which returned 
>> false from `SortPolicy.call()` function if root item has no children. This 
>> function is called from `TreeTableView.sort()` line #1863. When the returned 
>> value is false then line #1885 gets executed, which removes the sort order 
>> that was added.
>> 
>> Fix: The fix for [JDK-8256283](https://bugs.openjdk.org/browse/JDK-8256283) 
>> is modified to return true instead. Added a test that fails without and 
>> passes with fix.
>
> Ambarish Rapte has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   review comment: correct test name

Marked as reviewed by kcr (Lead).

-------------

PR: https://git.openjdk.org/jfx/pull/825

Reply via email to