On Wed, 13 Jul 2022 19:48:21 GMT, Andy Goryachev <d...@openjdk.org> wrote:

> - sampling at 1/3 of screen height instead of the very top to avoid hitting 
> OS UI found on the newer Macs with a notch
> - change applies to all platforms

Given what this test is trying to test, the proposed fix seems fine. I confirm 
that this test fails on my Mac M1 without the fix and passes with the fix.

One thing I just spotted is that this test makes the same mistake as 
`MouseLocationOnScreenTest -- see 
[JDK-8289611](https://bugs.openjdk.org/browse/JDK-8289611) -- in that it uses 
the bounds rather than the visual bounds of the screen. You can either look 
into that as well, or leave it as a fix for another day.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.org/jfx/pull/826

Reply via email to