On Mon, 18 Jul 2022 15:43:06 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix issue with IDE-indicated unused statement > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java > line 3113: > >> 3111: adjustPosition(); >> 3112: } >> 3113: recalculating = false; > > Is it likely that this method might get an exception? I was wondering whether > the assignment to false should be in a try / finally. If there is no probable > way an exception could occur, or if an exception is non-recoverable (which is > quite possible), then no need for a try / finally. Good question. There should be no non-recoverable exceptions in the VirtualFlow specific code. However, since IndexedCell.updateItem() and others might get called from this method, exceptions there might propagate. My initial thought was to fail-fast, but it is probably better to use a try/finally so that at least this method is still "working" somehow. I'll add that. ------------- PR: https://git.openjdk.org/jfx/pull/836
