On Thu, 28 Jul 2022 14:59:06 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
> The changes around KeyHandler might seem to be excessive for the scope of > this PR. They do indeed. > I think that moving the focus-related functionality next to the other focus > functions in the Scene class is a safe and straightforward change, and it > makes it easier to work with the code in the future. Be that as it may, this sort of refactoring is discouraged, especially in the case of a fix you want to get in late in the release (we have 3 days left before the RDP2 deadline of JavaFX 19). This will cause extra time for the reviewers and could jeopardize getting it into the release. It would have been better to save this change for a future bug fix. ------------- PR: https://git.openjdk.org/jfx/pull/852
