On Fri, 5 Aug 2022 10:44:55 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 11 additional >> commits since the last revision: >> >> - 8235491: whitespace >> - 8235491: additional tests >> - Merge remote-tracking branch 'origin/master' into 8235491.isselected >> - 8235491: javadoc >> - 8235491: tree table view >> - Merge remote-tracking branch 'origin/master' into 8235491.isselected >> - 8235491: review comments >> - 8235491: whitespace >> - 8235491: javadoc >> - 8235491: 2022 >> - ... and 1 more: https://git.openjdk.org/jfx/compare/262a884f...ad3c70b9 > > a bit confused about the [csr](https://bugs.openjdk.org/browse/JDK-8290741) - > shouldn't that be focused entirely on SelectionModel.isSelected)? That's > where we clarify the contract - all changes to TableXXSelectionModels are > implementation changes, fixing their contract violation. So I would expect > these not to be mentioned at all in the csr. > > BTW: isSelected is _not_ a convenience method - that's already changed here, > all mentions of its being so should be removed from the csr as well, IMO :) > @kleopatra : Various scenarios are pretty well covered by the existing tests. good - we seem to be lucky :) ------------- PR: https://git.openjdk.org/jfx/pull/839