On Wed, 17 Aug 2022 13:33:47 GMT, Kevin Rushforth <[email protected]> wrote:

>> Ambarish Rapte has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   review comment : mac NPE
>
> modules/javafx.graphics/src/main/java/javafx/scene/AccessibleRole.java line 
> 832:
> 
>> 830:      * <ul>
>> 831:      * <li> {@link AccessibleAttribute#TEXT} </li>
>> 832:      * <li> {@link AccessibleAttribute#ROLE_DESCRIPTION} </li>
> 
> What is the purpose of adding `ROLE_DESCRIPTION` here? It isn't listed 
> anywhere else except as an optional `Node` attribute.

Reason to include `ROLE_DESCRIPTION` explicitly is that role description is 
fetched and read by the accessibility client application.
The change in MacAccessible.java line 1302 and in WinAccessible line 799, are 
specifically for ROLE_DESCRIPTION.
Windows Narrator appends this role description after dialog title.

-------------

PR: https://git.openjdk.org/jfx/pull/873

Reply via email to