On Wed, 17 Aug 2022 12:02:04 GMT, Ambarish Rapte <[email protected]> wrote:

> Update libjpeg to current version release [9e](http://www.ijg.org/) of 
> 16-Jan-2022
> 
> reference: https://jpegclub.org/reference/reference-sources/
> 
> Verified all test run on Windows and MacOS

Looks good. I tested on all three platforms. I left a couple comments on 
questionable-looking indentation.

modules/javafx.graphics/src/main/native-iio/libjpeg/jdcolor.c line 446:

> 444:      ci++, compptr++) {
> 445:       if (! compptr->component_needed)
> 446:     continue;        /* skip uninteresting component */

The indentation looks off here.

modules/javafx.graphics/src/main/native-iio/libjpeg/jdcolor.c line 882:

> 880:     for (ci = 0; ci < cinfo->num_components; ci++)
> 881:       if (cinfo->comp_info[ci].component_needed)
> 882:     i++;        /* count output color components */

Indentation?

modules/javafx.graphics/src/main/native-iio/libjpeg/jdmaster.c line 181:

> 179:      ci++, compptr++)
> 180:       if (compptr->component_needed)
> 181:     i++;    /* count output color components */

intendation?

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.org/jfx/pull/874

Reply via email to