On Thu, 18 Aug 2022 09:51:53 GMT, Jeanette Winzenburg <faste...@openjdk.org> 
wrote:

>> Andy Goryachev has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   8292353: added tests
>
> modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableRow.java 
> line 448:
> 
>> 446:         }
>> 447: 
>> 448:         boolean isSelected = !sm.isCellSelectionEnabled() && 
>> sm.isSelected(index, null);
> 
> this is different from TableRow (which uses isSelected(index)) - why?
> 
> And we don't seem to have complete test coverage for row selection (otherwise 
> this issue would have shown somewhere :) - please add test/s that fail/pass 
> before/after the fix, respectively

updated and added tests.

-------------

PR: https://git.openjdk.org/jfx/pull/875

Reply via email to