On Fri, 26 Aug 2022 05:48:54 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Issue: >> When Narrator is running, >> 1. Deleting last character from `TextField` throws >> `IllegalArgumentException`, and >> 2. Deleting last character from `TextArea` throws `NPE`. >> >> Fix: >> When character is deleted, we receive an offset larger by one than the >> current text length. This scenario needs to be handled correctly. >> The change in `Text.java` fixes the NPE with TextArea, and, >> The change in `WinTextRangeProvider.java` fixes the IllegalArgumentException >> with TextField. >> >> To observe the issue. >> 1. Run any program with TextField and/or TextArea >> 3. Launch Windows Narrator >> 4. Delete the last character from TextField / TextArea >> 5. Observe the related Exception > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > change the fix for TextArea Exception Looks good. ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.org/jfx/pull/884
