On Wed, 31 Aug 2022 17:21:33 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Rename showing property to shown as it is already used in subclasses > > modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java > line 302: > >> 300: * ObservableValue<String> globalProperty = new >> SimpleStringProperty("A"); >> 301: * >> 302: * // bind label's text to a global property only when it is shown: > > "a label's" `label` here is referring to the variable name, I think `a label` might be confusing -- I've changed it to `the label` for now. ------------- PR: https://git.openjdk.org/jfx/pull/830