On Wed, 10 Aug 2022 09:40:02 GMT, Ajit Ghaisas <[email protected]> wrote:

>> A null check has been added to below SpinnerValueFactory classes in 
>> valueProperty() ChangeListeners-
>> - `IntegerSpinnerValueFactory`
>> - `LocalDateSpinnerValueFactory`
>> - `LocalTimeSpinnerValueFactory`
>> - `ListSpinnerValueFactory`
>> 
>> Added 5 tests that detect NPE for above 4 Spinner factories.
>> Only `DoubleSpinnerValueFactory` already had a valid null check - so the 
>> test for it passes before and after.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Simplify null asserts

Looks good.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.org/jfx/pull/865

Reply via email to