On Wed, 7 Sep 2022 11:59:42 GMT, Johan Vos <j...@openjdk.org> wrote:
>> Ao Qi has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> revert
>
> build.gradle line 313:
>
>> 311: } else if (IS_MAC && OS_ARCH != "x86_64" && OS_ARCH != "aarch64") {
>> 312: fail("Unknown and unsupported build architecture: $OS_ARCH")
>> 313: } else if (IS_LINUX && OS_ARCH != "i386" && OS_ARCH != "amd64" &&
>> OS_ARCH != "aarch64" && OS_ARCH != "loongarch64") {
>
> this could be simplified with
> `... && !IS_LOONGARCH64` which avoids the more error-prone duplicate
> "loongarch64" string.
> (the same applies to replacing the aarch64 check with !IS_AARCH64)
Done.
> modules/javafx.media/src/main/native/gstreamer/projects/linux/avplugin/Makefile
> line 36:
>
>> 34: -ffunction-sections -fdata-sections
>> 35:
>> 36: ifeq (,$(findstring $(ARCH), aarch64 loongarch64))
>
> This will work, but I wonder if we should revert the test: we now always
> assume that msse2 is supported, unless we are on an architecture which we
> know doesn't support it. It might be safer to only ask for msse2 support if
> we are really sure it is supported by the architecture (which currently means
> a check on x32 and x64)
Done.
-------------
PR: https://git.openjdk.org/jfx/pull/888
