On Fri, 30 Sep 2022 09:09:33 GMT, Jeanette Winzenburg <[email protected]>
wrote:
>> Fixed memory leak by using weak listeners and making sure to undo everything
>> that has been done to MenuBar/Skin in dispose().
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/SkinMemoryLeakTest.java
> line 94:
>
>> 92: public void testMemoryLeakSameSkinClass() {
>> 93: showControl(control, true);
>> 94: installDefaultSkin(control);
>
> no - here we test the isolated skin installation, no need for actually
> showing it. Please don't change the semantic of existing tests.
So here we have a problem - I know that the memory leak is fixed (I've tested
using VisualVM in a real application), but without this change, or without
adding a StageLoader, the test fails.
Any suggestions?
-------------
PR: https://git.openjdk.org/jfx/pull/906
