On Tue, 4 Oct 2022 16:06:00 GMT, Jeanette Winzenburg <[email protected]> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 20 additional >> commits since the last revision: >> >> - Merge branch 'openjdk:master' into 8290844.skin.install >> - 8290844: unit tests >> - Merge remote-tracking branch 'origin/master' into 8290844.skin.install >> - 8290844: review comments >> - 8290844: review comments >> - Merge remote-tracking branch 'origin/master' into 8290844.skin.install >> - 8290844: review comments >> - 8290844: review comments >> - Merge remote-tracking branch 'origin/master' into 8290844.skin.install >> - 8290844: javadoc >> - ... and 10 more: https://git.openjdk.org/jfx/compare/74f90618...d954aafc > > modules/javafx.controls/src/main/java/javafx/scene/control/Skin.java line 90: > >> 88: */ >> 89: default public void install() { } >> 90: > > what about calling install more than once? There are arguments for either: > > - in symmetry to dispose, it should be allowed > - regarding this as an "out-sourced" part of the constructor - to > allow/enforce proper cleanup - it shouldn't > > whatever the decision, it must be specified re-phrased the comment, please let me know if the new version is clearer (or suggest an alternative if not). ------------- PR: https://git.openjdk.org/jfx/pull/845
