On Tue, 18 Oct 2022 22:15:35 GMT, Douglas Held <d...@openjdk.org> wrote:

>> The JavaDoc for equals had a copy/paste error. I normalized the text based 
>> on the JavaDoc for method java.awt.Point#equals. ~~I also changed formatting 
>> in the method signatures of equals(), hashCode() and toString().~~
>> 
>> For good measure, some kind of copy/paste detection should probably be added 
>> to the many automated checks. For the entire OpenJDK project.
>
> Douglas Held has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Update Point3D.java
>   
>   Per review

modules/javafx.graphics/src/main/java/javafx/geometry/Point3D.java line 414:

> 412:     /**
> 413:      * Indicates whether some other object is "equal to" this one.
> 414:      * Two instances of Point3D are equal if the return values of their

`Point3D` also needs `@code`.

modules/javafx.graphics/src/main/java/javafx/geometry/Point3D.java line 418:

> 416:      *
> 417:      * @param obj the reference object with which to compare
> 418:      * @return true if this Point3D is the same as the obj argument; 
> false otherwise

`Point3D`, `true`, `false` and `obj` need `@code`.

-------------

PR: https://git.openjdk.org/jfx/pull/913

Reply via email to