On Wed, 2 Nov 2022 17:05:10 GMT, Lukasz Kostyra <[email protected]> wrote:

> Reproduction code was not provided, I wasn't able to reproduce the 
> circumstances in which the issue occurs. On our side it seems like 
> `WindowStage.getPlatformWindow()` will not return null, however it is also 
> difficult to reject the possibility that some custom user code might trigger 
> an edge-case where a null will be returned.
> 
> Adding these checks is not an intrusive change to our code, it is in fact an 
> extra null-check added to already existing checks, but it might prevent the 
> exception from appearing in the future.
> 
> I checked other places in our code using `WindowStage.getPlatformWindow()` 
> and none require a null check.

This pull request has now been integrated.

Changeset: 01735b33
Author:    Lukasz Kostyra <[email protected]>
Committer: Ambarish Rapte <[email protected]>
URL:       
https://git.openjdk.org/jfx/commit/01735b3389536be69e34c224e5d9de0ce7e39886
Stats:     5 lines in 1 file changed: 2 ins; 0 del; 3 mod

8265835: Exception in Quantum due to null platformWindow

Reviewed-by: arapte

-------------

PR: https://git.openjdk.org/jfx/pull/935

Reply via email to