On Mon, 7 Nov 2022 16:29:42 GMT, Ambarish Rapte <[email protected]> wrote:
>> This issue was uncovered when running the test added in PR: >> https://github.com/openjdk/jfx/pull/910 >> The JUnit5 tests using Params API fails to compile. >> >> Fix: >> Change dependency of `junit-jupiter-params` from runtime to compile time. >> From: >> https://junit.org/junit5/docs/current/user-guide/#overview-what-is-junit-5: >> it can be understood that packages of JUnit Jupiter other than `TestEngine` >> are required for test compilation and >> JUnit Platform serves as a foundation for [launching testing >> frameworks](https://junit.org/junit5/docs/current/user-guide/#launcher-api) >> >> It seems that changing dependency of this one package is sufficient for this >> fix. > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > add test We have other tests which use `@RunWith(Parameterized.class)` just fine (for example, SkinMemoryLeakTest). Is this about mixing junit4 and junit5 classes? Do we need to make changes in other tests? ------------- PR: https://git.openjdk.org/jfx/pull/939
