On Tue, 8 Nov 2022 16:40:11 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8295078: Replace JUnit4 with Junit5 imports > > modules/javafx.graphics/src/test/java/test/javafx/scene/layout/AnchorPaneTest.java > line 765: > >> 763: double snappedPaddingY = child.snapPositionY(padding); >> 764: >> 765: assertEquals(snappedPaddingX, boundsInParent.getMinX(), 0.0001); > > EPSILON constant perhaps? Not sure if this is worth it for just 2 occurrences. In general I always try not to clutter the test class with things used in only one or two test methods. ------------- PR: https://git.openjdk.org/jfx/pull/910
