> The root problem is actually broader than stated in the JBS issue. This PR > now translates screencoordinates from absolute coordinates into coordinates > that take the platformScale into account. > The whole process is complicated by the fact that throughout our code, we use > e.g. `x` and `y` without clearly stating if those are absolute, logical, > screen or rendering coordinates. > I believe the most consistent approach is to have the different entry points > (e.g. a Glass Window or a JFXPanel) to deal with platformScale before passing > screen coordinates. This is already done in the Glass approach, and this PR > does the same in JFXPanel. That means some code is duplicated, but since this > is only about 12 lines, and said code lives in 2 different modules, I think > it's not worth the hassle of moving that into e.g. the base module.
Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Process reviewer comments. Use Math.round() instead of Math.floor() for coordinates ------------- Changes: - all: https://git.openjdk.org/jfx/pull/924/files - new: https://git.openjdk.org/jfx/pull/924/files/783c45a5..4dd021c2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=924&range=03 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=924&range=02-03 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jfx/pull/924.diff Fetch: git fetch https://git.openjdk.org/jfx pull/924/head:pull/924 PR: https://git.openjdk.org/jfx/pull/924
