On Wed, 9 Nov 2022 19:14:10 GMT, Andy Goryachev <[email protected]> wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/PixelBufferDrawTest.java
>> line 189:
>>
>>> 187:
>>> 188: private void compareColor(Color exp, Color act) {
>>> 189: Assert.assertEquals(exp.getRed(), act.getRed(), 0.01);
>>
>> Since the tolerance value is used 4 times, maybe consider using a variable?
>> Since this is preexisting, I'll approve it anyway and leave it up to you as
>> to whether to change it.
>
> Since someone initially chose a value w/o justification, perhaps we should
> create a constant and describe it (using Kevin's comment as a starting point).
I will update it.
-------------
PR: https://git.openjdk.org/jfx/pull/944
