On Thu, 10 Nov 2022 20:00:28 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> A race condition exists where a derived color depends on another derived >> color which has not been yet defined or processed. The only side effect of >> this condition is a ClassCastException - the color eventually gets resolved. >> >> Solution: initialize the derived color to transparent earlier to suppress >> the exception. >> >> This was also a test bug https://bugs.openjdk.org/browse/JDK-8198604 > > modules/javafx.controls/src/main/resources/com/sun/javafx/scene/control/skin/modena/modena.css > line 382: > >> 380: >> 381: /* avoid race condition during initialization */ >> 382: -fx-table-cell-border-color: transparent; > > A bit of a nitpick, but this should be next to the other cell colors, so in > line 360 under `-fx-cell-focus-inner-border`. > Also, we should probably add a description to the color like the other > variables have here instead of explaining why it is here. :) 1) good point, let's move it there 2) the color name is self-explanatory, but why it is there is not. Perhaps I should also include the ticket number for reference? ------------- PR: https://git.openjdk.org/jfx/pull/947
