On Wed, 16 Nov 2022 00:20:19 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8206430: default timeout 15 > > tests/system/src/test/java/test/util/Util.java line 317: > >> 315: * @param args - command line arguments >> 316: */ >> 317: public static <T extends Application> void launch ( > > This looks like a useful utility. I think it would be helpful to either > remove the timeout parameter entirely, or else have a variant of this that > doesn't take the timeout value, and use a default timeout value. Most tests > use 10 or 15 seconds so standardizing on 15 seems reasonable. > > Also, many of the tests use `Platform.startup` since they don't need to > launch an application. Have you looked at providing a similar utility method > for those cases? 1. added a method with 15 second default. There are only 4 remaining that use custom timeout, the first two use 5, the other two 50: test.javafx.embed.swing.JFXPanelTest.doSetupOnce() test.javafx.embed.swing.SwingFXUtilsTest.doSetupOnce() test.javafx.embed.swing.SwingNodeMemoryLeakTest.setupOnce() test.javafx.embed.swing.SwingNodeScaleTest.setupOnce() ------------- PR: https://git.openjdk.org/jfx/pull/950
