On Wed, 16 Nov 2022 19:50:34 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8206430: util startup
>
> tests/system/src/test/java/test/javafx/scene/lighting3D/DirectionalLightTest.java
> line 67:
>
>> 65: public static void exit() {
>> 66: Util.shutdown();
>> 67: }
>
> This causes the test to fail. The superclass already does a shutdown, so the
> subclass must not.
yes, just noticed that, thank you. fixed in the latest commit.
> tests/system/src/test/java/test/util/Util.java line 362:
>
>> 360: try {
>> 361: String msg = "Timeout waiting for FX runtime to start";
>> 362: Assert.assertTrue(msg, startupLatch.await(TIMEOUT,
>> TimeUnit.MILLISECONDS));
>
> I recommend to standardize on 15 seconds like you did for launch (the ones
> you replaced were mostly a mix of 10 or 15 seconds). Maybe you could create a
> STARTUP_TIMEOUT constant field?
good idea, thanks!
-------------
PR: https://git.openjdk.org/jfx/pull/950
