>> - we probably should mention that the gradle build should be run after >> initial checkout, including sdk and apps. This will load and build the >> dependencies (lucene). > That is explained in the main page - > https://wiki.openjdk.org/display/OpenJFX/Building+OpenJFX, or at least should > be, as it isn't an Eclipse-specific step. There is a mention of this in the > Using Eclipse section.
I'd suggest to mention the need to rebuild using command line in the section Import the Eclipse Projects, since Eclipse will complain about missing dependencies. Perhaps provide the gradle command and a link to the "building.." page. Cheers, -andy From: Nir Lisker <[email protected]> Date: Tuesday, 2022/11/15 at 09:44 To: Andy Goryachev <[email protected]> Cc: Nir Lisker <[email protected]>, [email protected] <[email protected]> Subject: [External] : Re: RFR: 8221708 Update Eclipse project files [v4] - the screenshots are outdated, using much older version of Eclipse, the UI has been changed a bit. The latest Eclipse won't work with java19 without a separate plugin, but i am sure they will fix it soon. Yes, I will need to delete all the projects and re-import in order to create the new screenshot. The separate plugin support is explained under "Configure Eclipse to use the latest JDK". Each Eclipse release requires a plugin for the simultaneously released Java version, It is "fixed" in the next version, but then you need another plugin for the new release. - there is an option to 'ignore projects already in the workspace' and I think it must be turned on (I was getting a warning). If you are importing for the first time, no project will already be in the workspace, so it doesn't matter. If you are re-importing it's up to you if you want to ignore them or not, I would say. - we probably should mention that the gradle build should be run after initial checkout, including sdk and apps. This will load and build the dependencies (lucene). That is explained in the main page - https://wiki.openjdk.org/display/OpenJFX/Building+OpenJFX, or at least should be, as it isn't an Eclipse-specific step. There is a mention of this in the Using Eclipse section. On Tue, Nov 15, 2022 at 6:54 PM Andy Goryachev <[email protected]<mailto:[email protected]>> wrote: Nir, thank you so much! A few minor corrections might be needed. in Import the Eclipse Projects: - the screenshots are outdated, using much older version of Eclipse, the UI has been changed a bit. The latest Eclipse won't work with java19 without a separate plugin, but i am sure they will fix it soon. - there is an option to 'ignore projects already in the workspace' and I think it must be turned on (I was getting a warning). - we probably should mention that the gradle build should be run after initial checkout, including sdk and apps. This will load and build the dependencies (lucene). Perhaps we should also add a section dedicated to configuring error levels, as the default configuration turns off important warnings and enables too many unimportant ones. Thank you again -andy From: openjfx-dev <[email protected]<mailto:[email protected]>> on behalf of Nir Lisker <[email protected]<mailto:[email protected]>> Date: Monday, 2022/11/14 at 18:09 To: [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>> Subject: Re: RFR: 8221708 Update Eclipse project files [v4] On Sun, 13 Nov 2022 02:27:55 GMT, John Hendrikx <[email protected]<mailto:[email protected]>> wrote: >> See https://bugs.openjdk.org/browse/JDK-8221708 > > John Hendrikx has updated the pull request incrementally with one additional > commit since the last revision: > > Fix controls classpath I updated https://wiki.openjdk.org/display/OpenJFX/Using+an+IDE#UsinganIDE-UsingEclipse. ------------- PR: https://git.openjdk.org/jfx/pull/930
