On Tue, 22 Nov 2022 18:39:43 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autoboxed)
> - Remove unnecessary semi-colons (at end of class definitions, or just
> repeated ones)
> - Remove redundant super interfaces (interface that is already inherited)
> - Remove unused type parameters
> - Remove declared checked exceptions that are never thrown
> - Add missing `@Override` annotations
Looks good overall. Approval pending decisions on the few outstanding comments.
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/LinuxAbsoluteInputCapabilities.java
line 85:
> 83: }
> 84: Map<Integer, LinuxAbsoluteInputCapabilities> caps =
> 85: new HashMap<>();
Might as well put on the same line.
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/LinuxStatefulMultiTouchProcessor.java
line 42:
> 40:
> 41: private final Map<Integer, Integer> slotToIDMap =
> 42: new HashMap<>();
Same line. There are more places where this formatting can be fixed, but it's
up to you.
modules/javafx.graphics/src/main/java/com/sun/glass/ui/win/WinHTMLCodec.java
line 157:
> 155: htmlPrefix = "<HTML>";
> 156: htmlSuffix = "</HTML>";
> 157: if( -1 == stUpContext.indexOf("<BODY") ) {
Might as well fix the spacing for `if`.
modules/javafx.graphics/src/main/java/com/sun/prism/j2d/J2DPresentable.java
line 194:
> 192:
> 193: @Override
> 194: public void setOpaque(boolean opaque) {
Indentation
modules/javafx.graphics/src/main/java/com/sun/prism/j2d/J2DPrismGraphics.java
line 1433:
> 1431:
> 1432: @Override
> 1433: public void setClipRectIndex(int index) {
Indentation
-------------
PR: https://git.openjdk.org/jfx/pull/960
