> Note: I ran into a `javac` compiler bug while replacing types with diamond
> operators (ecj has no issues). I had two options, add a
> `SuppressWarnings("unused")` or to use a lambda instead of a method reference
> to make `javac` happy. I choose the later and added a comment so it can be
> fixed once the bug is fixed. I've reported the issue here:
> https://bugs.openjdk.org/browse/JDK-8297428
>
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autoboxed)
> - Remove unnecessary semi-colons (at end of class definitions, or just
> repeated ones)
> - Remove redundant super interfaces (interface that is already inherited)
> - Remove unused type parameters
> - Remove declared checked exceptions that are never thrown
> - Add missing `@Override` annotations
John Hendrikx has updated the pull request incrementally with two additional
commits since the last revision:
- Revert read only property instanceof checks
Added SuppressWarnings("cast") as these checks should be retained
- Replace StubToolkit casts with asserts
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/959/files
- new: https://git.openjdk.org/jfx/pull/959/files/1341a438..76acacb8
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=959&range=04
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=959&range=03-04
Stats: 151 lines in 23 files changed: 100 ins; 25 del; 26 mod
Patch: https://git.openjdk.org/jfx/pull/959.diff
Fetch: git fetch https://git.openjdk.org/jfx pull/959/head:pull/959
PR: https://git.openjdk.org/jfx/pull/959
