On Fri, 2 Dec 2022 17:45:23 GMT, Andy Goryachev <[email protected]> wrote:

>> as determined by SkinMemoryLeakTest (remove line 179) and a leak tester
>> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>> 
>> caused by:
>> - adding and not removing listeners
>> - adding and not removing event handlers/filters
>> 
>> NOTE:
>> this fix requires [JDK-8294809](https://bugs.openjdk.org/browse/JDK-8294809) 
>> ListenerHelper
>
> Andy Goryachev has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains 27 commits:
> 
>  - Merge remote-tracking branch 'origin/master' into
>    8295806.table.view.skin
>  - Merge remote-tracking branch 'origin/master' into
>    8295806.table.view.skin
>  - Merge remote-tracking branch 'origin/master' into
>    8295806.table.view.skin
>  - 8295806: placeholder
>  - 8295806: plugged the leak
>  - Merge remote-tracking branch 'origin/8294809.listener.helper' into 
> 8295806.table.view.skin
>  - 8294809: map change listener
>  - Merge remote-tracking branch 'origin/master' into 8294809.listener.helper
>  - Merge remote-tracking branch 'origin/master' into 8295806.table.view.skin
>  - 8294809: generics
>  - ... and 17 more: https://git.openjdk.org/jfx/compare/e64e1292...ba84ea24

Fix looks good to me!

-------------

Marked as reviewed by aghaisas (Reviewer).

PR: https://git.openjdk.org/jfx/pull/929

Reply via email to