On Mon, 5 Dec 2022 20:17:04 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> I do agree with @kevinrushforth here. >> >> It might be borderline useful to enable the warning once just to see if >> there are any bugs or perhaps to clean up the most obvious cases, but it >> probably makes little sense to enable the said warning for large and long >> lived code bases like this one. > > just to clarify: > 1. I am ok with this code change, the typecast is unnecessary > 2. I agree with Kevin that this particular warning (unnecessary cast) is of > little value, especially in the large and long lived code bases. I wrote what I think in [this comment](https://github.com/openjdk/jfx/pull/960#issuecomment-1325782856). Even if in this specific case the cast should not be changed, the warning is very useful to have since it encapsulates non-numeric types as well. ------------- PR: https://git.openjdk.org/jfx/pull/960
