On Tue, 18 Oct 2022 23:41:05 GMT, Andy Goryachev <[email protected]> wrote:
> as determined by SkinMemoryLeakTest (remove line 166) and a leak tester > https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java > > Affected skins: > - ColorPicker > - DatePicker > - ComboBox > > caused by: > - out-of-order modification of the control property (skin.install) > - adding skin nodes and not removing them in dispose() > - adding listeners and not removing them in dispose() > > NOTE: the fix will require not only ListenerHelper > [JDK-8294809](https://bugs.openjdk.org/browse/JDK-8294809) but also > Skin.install() [JDK-8290844](https://bugs.openjdk.org/browse/JDK-8290844) > changes. This pull request has now been integrated. Changeset: bb139208 Author: Andy Goryachev <[email protected]> URL: https://git.openjdk.org/jfx/commit/bb139208222d7c045be0a3c6f07ef15edcb1625b Stats: 185 lines in 6 files changed: 82 ins; 41 del; 62 mod 8295531: ComboBoxBaseSkin: memory leak when changing skin Reviewed-by: aghaisas ------------- PR: https://git.openjdk.org/jfx/pull/922
