On Wed, 7 Dec 2022 10:25:50 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 36 commits: >> >> - 8295809: cleanup >> - Merge remote-tracking branch 'origin/master' into >> 8295809.tree.table.view.skin >> - Merge remote-tracking branch 'origin/master' into >> 8295809.tree.table.view.skin >> - Merge branch '8295806.table.view.skin' into 8295809.tree.table.view.skin >> - Merge remote-tracking branch 'origin/master' into >> 8295806.table.view.skin >> - Merge branch '8295806.table.view.skin' into 8295809.tree.table.view.skin >> - Merge remote-tracking branch 'origin/master' into >> 8295806.table.view.skin >> - 8295809: cleanup >> - Merge branch '8295806.table.view.skin' into 8295809.tree.table.view.skin >> - Merge remote-tracking branch 'origin/master' into >> 8295806.table.view.skin >> - ... and 26 more: https://git.openjdk.org/jfx/compare/6f36e704...cfa05b79 > > modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/SkinCleanupTest.java > line 277: > >> 275: } >> 276: >> 277: @Ignore("JDK-8295809") // TODO probably need to verify the result >> of listener action, > > We need to file a follow-on bug to modify or cleanup these ignored tests in > future. > Use the bug ID of the newly filed bug with `@Ignore` tag for these two tests. thank you for noticing! the tests are changed to validate functionality rather than implementation detail, i.e. that the tree table row skin tracks the virtual flow width with or without skin replacement. > modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/SkinMemoryLeakTest.java > line 238: > >> 236: >> 237: // >> 238: Spinner.class > > This seems an unrelated change. cleaned up. ------------- PR: https://git.openjdk.org/jfx/pull/931
